Hi, tl;dr Any showstopper for using Qt5 instead of Qt4 for WebODF tools? The WebODF build system relies on qtjsruntime to run the tests. Now qtjsruntime is currently based on Qt4, which uses a very old version of WebKit. There is the QtWebKit 2.3 project (see http://blogs.kde.org/2012/11/14/introducing-qtwebkit-23) which brings in a newer WebKit version, that is also used by most Linux distributions as standard replacement for the official QtWebKit that is part of the released Qt sources, even the latest 4.8.6 But the self-compiled Qt 4.8.5 on CI does not have that yet (from what I can tell), and people developing on Windows or OSX might also seem to need to do some extra work to get QtWebKit 2.3 installed, so increases the hurdles for them. Problem with such an old WebKit as in normal Qt is that it is buggy and far behind. And we start to add hacks in WebODF code just to workaround bugs there, as discussed in https://github.com/kogmbh/WebODF/pull/550 So moving to Qt5, which uses a more modern version of WebKit (and/or soon Blink, see http://blog.qt.digia.com/blog/2013/09/12/introducing-the-qt-webengine/ ) seems like a good solution for the problems noted above. There is currently on other subproject in WebODF based on Qt4, nativeQtClient, but that has bitrotted and needs some work to be resurrected. And when doing that it makes more sense to use Qt5 as well, because that should enable to reach more platforms thanks to Qt5. So, any reason not to prepare a patch which switches qtjsruntime to Qt5 (and perhaps remove nativeQtClient for now)? Everybody has Qt5 installed on their development enviroment or could do so? Cheers Friedrich -- Friedrich W. H. Kossebau // KO GmbH http://kogmbh.com/legal/
On 1 May 2014 01:02, Friedrich W. H. Kossebau
Hi,
tl;dr Any showstopper for using Qt5 instead of Qt4 for WebODF tools?
None from me. OSX has Qt5 available via Brew, and the Windows installers all seem good. It would certainly make my life easier with the qtruntime tests -_- -- Philip Peitsch
On 04/30/2014 05:02 PM, Friedrich W. H. Kossebau wrote:
Hi,
tl;dr Any showstopper for using Qt5 instead of Qt4 for WebODF tools?
No problem for me either. Qt5 seems like a reasonable requirement. I do think that the way the browser component works has changed from 5.0 to 5.3. My suggestion is to port to 5.3 so the code can take advantage of the latest API. When that is done, the required version might be lowered to 5.2 or 5.1. Cheers, Jos
Am Montag, 5. Mai 2014, 09:39:35 schrieb Jos van den Oever:
On 04/30/2014 05:02 PM, Friedrich W. H. Kossebau wrote:
Hi,
tl;dr Any showstopper for using Qt5 instead of Qt4 for WebODF tools?
No problem for me either. Qt5 seems like a reasonable requirement.
Okay, so sounds we should soon go for that then. Though first need to make sure the CI system will also deal with it :) Thanks all for the (positive) feedback so far.
I do think that the way the browser component works has changed from 5.0 to 5.3.
Now, there is QtWebKit as official Qt module. It will be deprecated though in the future, once the new module for Web stuff which is based on Blink is done. Just, that module, last called QtWebEngine, is still not officially released, at least not part of Qt 5.3 and possibly not even as add-on. See http://qt-project.org/wiki/QtWebEngine So QtWebKit it is for now.
My suggestion is to port to 5.3 so the code can take advantage of the latest API. When that is done, the required version might be lowered to 5.2 or 5.1.
5.3 is not yet out, and might not be for a few more weeks (planned release date 7th May 2014 will not be hit, as even the RC is not yet out). And the new stuff for QtWebKit in 5.3, at least promoted, are only * Support for HTML5 Video Track. Subtitles and captions for HTML5 video. * Support for Indexed DB API. See http://www.w3.org/TR/IndexedDB/ * Improved support for Mac HiDPI mode (see http://qt-project.org/wiki/New-Features-in-Qt-5.3) thus not really interesting to us. Also do we not do too fancy things with the API right now. So going for Qt 5.2 for now I propose. Next step: making sure CI system can use Qt5 Cheers Friedrich -- Friedrich W. H. Kossebau // KO GmbH http://kogmbh.com/legal/
participants (3)
-
Friedrich W. H. Kossebau
-
Jos van den Oever
-
Philip Peitsch